[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    Bug#13027: KMail Bug: Forwarding messages with attachments
From:       Jacek Stolarczyk <jacek () mer ! chemia ! polsl ! gliwice ! pl>
Date:       2000-10-17 21:56:10
[Download RAW message or body]

Dnia 17 Oct 2000 23:40, Michael Haeckel wrote:
> Am Dienstag, 17. Oktober 2000 15:21 schrieb Jacek Stolarczyk:
> > Will something like like this patch help? We indeed should check if the
> > charset exists before setting it.
>
> If I also remove the second place where the charset is set, then it works
> for this problem.
>
You're right but what makes me wonder is why we have the line
msg->setCharset(charset());
twice in the code of KMMessage::createForward ? It has not been there a 
couple of days ago. It seems redundant. I haven't looked at the code 
thoroughly and I thought that one occurrence was enough.

Anyway, checking whether charset() returns an empty string before setting it 
to another message is definitely a right thing to do (other option would be 
to exit from setCharset if the argument is null or empty). Setting "charset=" 
in headers is clearly wrong.

I would consider removing the second msg->setCharset(charset()); putting
if (!charset.isEmpty()) before the first occurrence and possibly applying it 
even to the 2.0 release. But I'll leave the decision to Michael and Don.

Regards,

Jacek Stolarczyk
-- 
jstolarz@kde.org
Coordinator of Polish translations of KDE

[prev in list] [next in list] [prev in thread] [next in thread]