[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: Bug#11990: PATCH: Please review, Re: Bug#11990: REFRESH redirection does not work on http://stor
From:       Kurt Granroth <granroth () suse ! com>
Date:       2000-09-29 0:36:32
[Download RAW message or body]

Dirk Mueller wrote:
> > Anyway, I just removed the 'return QString::null;' and it works like a
> > charm.
> 
> strange, this code is also in since ages and nobody has noticed. Great that
> you found it, Kurt!
> 
> hmm, but its wrong then. because then it runs into found: and then it will
> assume latin1 for the whole document, which is plain wrong if its not latin1
> ;)
> 
> By looking at the code I guess it should return
> 
>   return QString::fromLatin1(data, len);
> 
> this means assuming latin1 as long as we didn't know the charset at that
> place yet. this seems to be correct as we will switch to the correct coded
> as soon as we got a metatag about it. 

That works for me..

> what still has to be tested is if it uses the correct encoding if it has
> been returned by the ioslave (the slave sends us a metadata object if there
> was a encoding-charset header line in the server header of the HTTP
> protocol). If that works as well, it should be committed. 
> 
> Anybody here wanting to play tester ? :)
 
..but I have no clue about charset issues or how to test them, so I'll
have to leave this to Lars (or somebody else) :-)
-- 
Kurt Granroth            | http://www.granroth.org
KDE Developer/Evangelist | SuSE Labs Open Source Developer
granroth@kde.org         | granroth@suse.com
           KDE -- Putting a Friendly Face on Unix

[prev in list] [next in list] [prev in thread] [next in thread]