[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [valgrind] [Bug 396290] [PATCH] Possible tool - allocfail
From:       Ivo Raisr <bugzilla_noreply () kde ! org>
Date:       2018-08-22 23:29:07
Message-ID: bug-396290-17878-jDI4jP3ClU () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=396290

--- Comment #20 from Ivo Raisr <ivosh@ivosh.net> ---
Thank you for your work. This is going to be a useful Valgrind tool.

I like the documentation for the latest patch. Reasoning explained well on
examples. You could mention that the default behaviour (fail unseen
allocations) can be heavily tuned by options which are described later.

As regards instrumentation: unfortunately I don't think the current scheme of
detecting function entry/return w.r.t. --toggle-fn is going to work.
Instruction instrumentation is done by blocks and their processing is mostly
orthogonal to the actual execution. I think Callgrind tool solves similar
problem - detecting when a function is entered and returned - try to have a
look there. I think it still suffers from some limitations on arm architecture,
though.

For coding style - please use explicit check for NULL or != NULL.
For example if (instr_callstack) => if (instr_callstack != NULL)

-- 
You are receiving this mail because:
You are watching all bug changes.=
[prev in list] [next in list] [prev in thread] [next in thread]