[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [digikam] [Bug 361047] Wishlist: make grouped images more prominently visible [patch]
From:       <bugzilla_noreply () kde ! org>
Date:       2017-02-22 9:26:12
Message-ID: bug-361047-17878-CqP4CHVB95 () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #62 from caulier.gilles@gmail.com ---
Jens,

I updated the patch to be compilable with current implementation from
git/Master. I don't introduce the SVG idea.

The result is not too bad. There are some problems with icons overlays, as
geolocation and grouped indicator.

I like the isdea to apply a background color of all grouped items when this one
is expanded. This color case of use need to be tested when more than one group
is present in same album and when there are expanded.


The grouped thumb frame work as expected, even if large thumbnails size is
selected in setup dialog.

Activating also all thumbnails info, as rating, tags, comments, file name,
date, etc, sound like not broken, as with previous version 1 or 2 of the patch.

I'm not happy with the patch where some hardcoded enum are used as well. The
code also depends of color theme used for icon view, and it's hardcoded.

I don't yet tested the CPU use when an album has a large amount of grouped
items. Typically, the grouped thumb frame must be cached in memory. This must
be fast, but i want to be sure that non time latency is not introduced by the
code.

Ti resume : the patch need to be adjust, polished and tested again and again.

Gilles Caulier

-- 
You are receiving this mail because:
You are watching all bug changes.=
[prev in list] [next in list] [prev in thread] [next in thread]