[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [plasmashell] [Bug 372717] on rtl langs the search bar isn't in the right position
From:       <bugzilla_noreply () kde ! org>
Date:       2016-11-30 12:52:22
Message-ID: bug-372717-17878-iDAJwa3K1u () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=372717

--- Comment #5 from ttv200@gmail.com ---
I found the problem and I write a patch:

In plasma-desktop git,
applets/kicker/package/contents/ui/MenuRepresentation.qml

Row 62:
LayoutMirroring.enabled: ((plasmoid.location == PlasmaCore.Types.RightEdge)
    || (Qt.application.layoutDirection == Qt.RightToLeft))

Row 353:
the search field:
when: (plasmoid.location == PlasmaCore.Types.RightEdge
    || (plasmoid.location != PlasmaCore.Types.RightEdge &&
mainRow.LayoutMirroring.enabled))

The idea was if the widget is on the right edge the layout will mirrored (the
side bar be on the right - try it and understand)
This cause problem - the search field overlap logout button on RTL lang
Because when the LayoutMirroring.enabled (on LTR when RightEdge and on RTL
langs) all the left and right switched
* (363) "anchors.right: parent.right" become "anchors.left: parent.left"
* (368) "anchors.rightMargin: ..." become "anchors.LeftMargin: ..."

So I think and I write patch with this thought:
Like that LTE with RightEdge is mirrored so RTL with LeftEdge should be (not
mirrored)

The Patch:

Replace rows 62-63 with:
LayoutMirroring.enabled: ((plasmoid.location == PlasmaCore.Types.RightEdge)
    || (Qt.application.layoutDirection == Qt.RightToLeft && plasmoid.location
!= PlasmaCore.Types.LeftEdge))

Replace rows 353-354 with:
when: (plasmoid.location == PlasmaCore.Types.RightEdge &&
Qt.application.layoutDirection == Qt.LeftToRight)
    || (plasmoid.location == PlasmaCore.Types.LeftEdge &&
Qt.application.layoutDirection == Qt.RightToLeft)

I tried the patch on my system and check LTR and RTL with right and left edged
panels

Can you apply the patch?

-- 
You are receiving this mail because:
You are watching all bug changes.=
[prev in list] [next in list] [prev in thread] [next in thread]