[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [kaffeine] [Bug 364261] New: Only "Breeze" iconset will be used, even with Oxygen configured
From:       JanKusanagi via KDE Bugzilla <bugzilla_noreply () kde ! org>
Date:       2016-06-12 23:37:19
Message-ID: bug-364261-17878 () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=364261

            Bug ID: 364261
           Summary: Only "Breeze" iconset will be used, even with Oxygen
                    configured
           Product: kaffeine
           Version: 2.0.1
          Platform: unspecified
                OS: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: NOR
         Component: general
          Assignee: mchehab@osg.samsung.com
          Reporter: jan-bugs@gmx.co.uk

Kaffeine 2.0.3 uses Breeze icons in the menus, even when system's configured
iconset is Oxygen.

I've found that in src/main.cpp, there is a function, iconThemeFunc() that
seems to handle this.

The function starts with this 'if' statement, on line 159 of current master:

if ((QIcon::themeName() != QLatin1String("breeze")
        && QIcon::themeName() != QLatin1String("oxgen"))
        || QIcon::themeName().isEmpty()) {

where we can see it looks for "oxgen" theme, instead of "oxygen", so it will
always default to "breeze" ;)

Thanks!


P.S.- I understand the decision to force either of these two iconsets, as
stated right before that function:
"// The icon Kaffeine needs are either at breeze or oxygen themes"

but I really think this should be optional, or a recommendation, or something
like that. I see no reason for people to have this program showing with a
completely alien iconset (for them), just because it's assumed other iconsets
are not complete enough.

What do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]