[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [konqueror] [Bug 346338] Icons on Konqueror's Introduction page are missing when certain AdBlock fil
From:       Wolfgang Bauer <wbauer () tmo ! at>
Date:       2015-04-22 17:06:36
Message-ID: bug-346338-17878-62VkB0IDKc () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=346338

--- Comment #6 from Wolfgang Bauer <wbauer@tmo.at> ---
(In reply to Andrea Iacovitti from comment #4)
> The problem here is we do not fully support ad-block rules and in our
> implemetation for a filter rule like this:
> /\/[0-9].*\-.*\-[a-z0-9]{4}/$script,xmlhttprequest,domain=keezmovies.
> com|spankwire.com|tube8.com
> we end up to consider only the regexpr part:
> \/[0-9].*\-.*\-[a-z0-9]{4}
> ignoring its options (the ones after '$' sign)

Oh. I somehow misread the rule as having a 'V' at the beginning instead of
'\/'.
That's why I was surprised that it matches at all...

(In reply to Andrea Iacovitti from comment #5)
> Created attachment 92145 [details]
> plausible patch

I tried the patch and can confirm that the icons indeed show up now with the
EasyList filter active.

I even tried to enable _all_ automatic filters.

There's only a problem with Corset (http://brianyi.com/corset.txt) which
specifies * as only filter rule. So not a bug in KHTML, although that filter
should maybe be removed.

-- 
You are receiving this mail because:
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]