[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [kdevplatform] [Bug 341875] Upload to ReviewBoard stopped working
From:       RJVB <rjvbertin () gmail ! com>
Date:       2014-12-16 11:25:08
Message-ID: bug-341875-17878-I7FxlljxQz () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=341875

--- Comment #9 from RJVB <rjvbertin@gmail.com> ---
Here's the unified diff between patchfiles saved from KDevelop 4.7 patchreview
and KDevelop 4.90.90 patchreview:

```
--- kioexec-kdev470.patch       2014-12-16 11:24:46.000000000 +0100
+++ kioexec-kdev49090.patch     2014-12-16 12:11:25.000000000 +0100
@@ -1,7 +1,7 @@
-diff --git kioexec/main.cpp kioexec/main.cpp
+diff --git a/kioexec/main.cpp b/kioexec/main.cpp
 index 06cd8f3..699e94f 100644
---- kioexec/main.cpp
-+++ kioexec/main.cpp
+--- a/kioexec/main.cpp
++++ b/kioexec/main.cpp
 @@ -21,6 +21,17 @@

  #include "main.h"
```

In short, ReviewBoard now apparently requires -p1 patches, while KDevelop 4.7
continues to make -p0 patches. That server change apparently became effective
last Saturday shortly after 21:48 Europe/Paris time.
Manual upload of the -p1 patch works, and I presume that editing a KDevelop 4.7
patch to be -p1 before uploading it will cause the upload to succeed too
(haven't tried that yet).

Is that a concious/voluntary change? I must say that p0 patches KDevelop
generates have been very useful to me, so I'd regret having to "upgrade" to a
p1 patch generation feature ...

-- 
You are receiving this mail because:
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]