[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [parley] [Bug 331149] Problem with implementation of grades and boxes and the working of '3 consecut
From:       Amarvir Singh <amarvir.ammu.93 () gmail ! com>
Date:       2014-02-21 21:15:10
Message-ID: bug-331149-17878-FmaGNUBiTs () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=331149

Amarvir Singh <amarvir.ammu.93@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/parl
                   |                            |ey/7ab775f4d860f7525dfe74a1
                   |                            |154cc3b9856db8ff

--- Comment #2 from Amarvir Singh <amarvir.ammu.93@gmail.com> ---
Git commit 7ab775f4d860f7525dfe74a1154cc3b9856db8ff by Amarvir Singh.
Committed on 15/02/2014 at 09:05.
Pushed by amarvirsingh into branch 'master'.

Fix grade computation and box highlighting

Fixes three issues in 3-right-answers mode:
1. Alternative learning mode: the next grade box lighted up, even though the
   question hasn't been answered correctly thrice consecutively
2. For yet unlearned words: if user answers correctly the first time, the grade
   should increase from 0 to 2. Reasoning: 0 to 1 for having learned the word,
   and 1 to 2 for correctly answered.
3. Grade from 0 to 1 was not increased correctly when user answered it
correctly.
   In case the word is answered correctly once, the next occurrence of the same
   word doesn't have the grade 1 box lit up. Starting a new session without
   answering thrice or answering wrong, results in the word being marked as
   unseen.
REVIEW: 115754

M  +13   -3    src/practice/practicestatemachine.cpp
M  +20   -3    src/practice/testentry.cpp
M  +4    -2    src/practice/testentry.h

http://commits.kde.org/parley/7ab775f4d860f7525dfe74a1154cc3b9856db8ff

-- 
You are receiving this mail because:
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]