[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [nepomuk] [Bug 324307] Nepomukindexer segfaults then core dumps ad finitum using 100% CPU
From:       Simeon Bird <bladud () gmail ! com>
Date:       2013-09-03 18:29:48
Message-ID: bug-324307-17878-FvnCxUOQIz () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=324307

Simeon Bird <bladud@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|http://commits.kde.org/nepo |http://commits.kde.org/nepo
                   |muk-core/9a4dcb1bffaef6c70a |muk-core/d14700f5a02653260a
                   |256fb3c2a759e6586e0da5      |a1129eb718f69d33e5c8a5
      Latest Commit|http://commits.kde.org/nepo |http://commits.kde.org/nepo
                   |muk-core/d14700f5a02653260a |muk-core/6e6e676bc519eae62d
                   |a1129eb718f69d33e5c8a5      |66a6b69c1a83788c7a570a

--- Comment #24 from Simeon Bird <bladud@gmail.com> ---
Git commit d14700f5a02653260aa1129eb718f69d33e5c8a5 by Simeon Bird.
Committed on 03/09/2013 at 06:05.
Pushed by sbird into branch 'KDE/4.11'.

FileIndexer: Really do not index file multiple times

In commit c441198286562924ad3980527913b4888bdcb7a6
I attempted to implement not re-indexing files which failed to index.

However, my code made no sense!

It attempted to set kext::indexingLevel to -1 if the nepomukindexer job
returned with an error. But, the KJob never set an error even if the
indexer returned 1, so nothing happened.

Even when this was fixed, it still didn't work, because I was updating
the indexingLevel of the current filename, not the resource URI of the
current filename.

So, to summarise, I was silly. This one works, and an easy way to test
it is to replace /usr/bin/nepomukindexer with:

 #!/bin/bash
 exit 1

M  +11   -6    services/fileindexer/fileindexingjob.cpp
M  +11   -3    services/fileindexer/fileindexingqueue.cpp

http://commits.kde.org/nepomuk-core/d14700f5a02653260aa1129eb718f69d33e5c8a5

--- Comment #25 from Simeon Bird <bladud@gmail.com> ---
Git commit 6e6e676bc519eae62d66a6b69c1a83788c7a570a by Simeon Bird.
Committed on 03/09/2013 at 06:29.
Pushed by sbird into branch 'KDE/4.11'.

FileIndexer: Check for nepomukindexer crashing.

It is not enough to check that the indexer returns 0.
We must also check that it did not crash, and, if it did,
return an error.

This patch also defines an error enum for FileIndexingJob.
REVIEW: 112475

M  +8    -4    services/fileindexer/fileindexingjob.cpp
M  +11   -2    services/fileindexer/fileindexingjob.h

http://commits.kde.org/nepomuk-core/6e6e676bc519eae62d66a6b69c1a83788c7a570a

-- 
You are receiving this mail because:
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]