[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [kdelibs] [Bug 324013] NULL pointer dereference in KPtyDevicePrivate::doWait
From:       Christopher Yeleighton <giecrilj () stegny ! 2a ! pl>
Date:       2013-08-29 17:54:40
Message-ID: bug-324013-17878-15TWmQRf2l () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=324013

--- Comment #4 from Christopher Yeleighton <giecrilj@stegny.2a.pl> ---
(In reply to comment #3)
> the test log indicates quite clearly that the root cause is a failure to
> open a pty.
> the test should do QVERIFY(p.pty()->isOpen()); right after instantiating the
> KPtyProcess.
> actual user code of KPtyProcess (konsole in particular) should be checked
> whether it does this check, too.

Library code should not rely on the customer observing complicated conditions
and transitions or otherwise we will crash.  I understand that is sometimes
necessary for efficiency reasons (e.g. invalid iterators) but I think this is
not the case this time.

-- 
You are receiving this mail because:
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]