[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [plasma] [Bug 320342] notes plasmoid doesn't visually change the text color on a plasma theme change
From:       Wolfgang Bauer <wbauer () tmo ! at>
Date:       2013-05-29 21:02:00
Message-ID: bug-320342-17878-DiuRunBax1 () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=320342

--- Comment #5 from Wolfgang Bauer <wbauer@tmo.at> ---
(In reply to comment #3)
> The patch only works for me if I also change the first line from
> m_textColor =
> Plasma::Theme::defaultTheme()->color(Plasma::Theme::ButtonTextColor);
> to 
> m_textColor = Plasma::Theme::defaultTheme()->color(Plasma::Theme::TextColor);
It does work with ButtonTextColor as well, it just may have an unexpected
result with certain themes which have different TextColor and ButtonTextColor.

And of course this should be used consistent everywhere in the applet. I just
now discovered that in configAccepted(), line 526 TextColor is used, in the
other 2 places (configChanged() and themeChanged()) TextButtonColor, so this
has been another bug...

Well, I guess using TextColor instead of TextButtonColor would be more correct
semantically.

So, IMHO the patch in reviewboard seems to be 100% ok now.

Thanks for the fast response! :-)

-- 
You are receiving this mail because:
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]