[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [plasma] [Bug 320342] notes plasmoid doesn't visually change the text color on a plasma theme change
From:       Anne-Marie Mahfouf <annma () kde ! org>
Date:       2013-05-29 18:37:31
Message-ID: bug-320342-17878-AKu5hkCRLF () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=320342

--- Comment #3 from Anne-Marie Mahfouf <annma@kde.org> ---
Hi, sorry, I got mixed up, I thought this was about the cursor color.

The patch only works for me if I also change the first line from
m_textColor =
Plasma::Theme::defaultTheme()->color(Plasma::Theme::ButtonTextColor);
to 
m_textColor = Plasma::Theme::defaultTheme()->color(Plasma::Theme::TextColor);

The patch is therefore:
diff --git a/applets/notes/notes.cpp b/applets/notes/notes.cpp
index 5c2ed70..0b6092c 100644
--- a/applets/notes/notes.cpp
+++ b/applets/notes/notes.cpp
@@ -356,8 +356,11 @@ void Notes::saveState(KConfigGroup &cg) const
 void Notes::themeChanged()
 {
     if (m_useThemeColor) {
-        m_textColor =
Plasma::Theme::defaultTheme()->color(Plasma::Theme::ButtonTextColor);
-        update();
+        m_textColor =
Plasma::Theme::defaultTheme()->color(Plasma::Theme::TextColor);
+        QTextCursor oldCursor = m_noteEditor->textCursor();
+        m_noteEditor->selectAll();
+        m_noteEditor->setTextColor(m_textColor);
+        m_noteEditor->setTextCursor(oldCursor);
     }
 }

also in configChanged, in line 192
        m_textColor =
Plasma::Theme::defaultTheme()->color(Plasma::Theme::ButtonTextColor);
should be
        m_textColor =
Plasma::Theme::defaultTheme()->color(Plasma::Theme::TextColor);

-- 
You are receiving this mail because:
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]