[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Oxygen] [Bug 304381] X-resource leak when using Eclipse and oxygen-gtk
From:       Ruslan Kabatsayev <b7.10110111 () gmail ! com>
Date:       2013-03-02 21:43:09
Message-ID: bug-304381-17878-TVxn2VnjQi () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=304381

--- Comment #11 from Ruslan Kabatsayev <b7.10110111@gmail.com> ---
Created attachment 77692
  --> https://bugs.kde.org/attachment.cgi?id=77692&action=edit
Proposed patch

@Hugo
Apparently, TileSet's h1 and h3 appear both 0: h1 is passed as 0 constant, h3
looks like gets subtracted from surface height which appears equal it. And
TileSet::isValid() checks for height()>0, where height = h1+h3.
So, should this check be changed somehow? Maybe
"(width()>0||height()>0)&&_surfaces.size() == 9"? instead of both width()>0 &&
height()>0?

The change is attached as a proposed patch. I'm not sure it's the way to go,
but at least I no longer reproduce this bug with the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]