[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 291052] Flicker when changing between Areas
From:       Aleix Pol <aleixpol () kde ! org>
Date:       2012-11-28 2:36:28
Message-ID: bug-291052-17878-5JB4mM7PSQ () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=291052

Aleix Pol <aleixpol@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/kdev
                   |                            |platform/cd3d48751c167ac547
                   |                            |682a559e98e7dd7aa425a3

--- Comment #4 from Aleix Pol <aleixpol@kde.org> ---
Git commit 8c22f2ffdc5b1df0c6b111868a5aca8debca5ced by Aleix Pol.
Committed on 28/11/2012 at 01:29.
Pushed by apol into branch 'master'.

Delay initialization of TextEditorWidget

This patch reduces the initialization of the loading a text document view
by delaying the initialization.
This is useful because when we change areas we close all the opened views
and then we reopen the new ones. The loading of document views was one of
the most expensive calls that happened there. This is now delayed to the
event loop so the view creation now is trivial by creating only an empty
widget that will be instantiated afterwards.

I'm not closing the bug for the moment, but it would be interesting to know
how it went, so feedback is welcome!

M  +38   -20   shell/textdocument.cpp
M  +6    -4    shell/textdocument.h

http://commits.kde.org/kdevplatform/8c22f2ffdc5b1df0c6b111868a5aca8debca5ced

--- Comment #5 from Aleix Pol <aleixpol@kde.org> ---
Git commit cd3d48751c167ac547682a559e98e7dd7aa425a3 by Aleix Pol.
Committed on 28/11/2012 at 03:30.
Pushed by apol into branch 'master'.

Don't resize the vertical IdealButtonBarWidget when it's empty

This greatly reduces the flickering on area switching. What was happening
is that when changing areas all buttons were removed and re-added. In this
process the button bar would shrink when empty and that would trigger a
re-layout of the whole GUI. Now we keep the width of the buttons we've
added.

This won't be a regression given that my previous commit improves the
behavior when there are no buttons on the button bar, so we won't get
a big gray area.

Now all the flickering when changing area should be gone.

M  +6    -0    sublime/ideal.cpp

http://commits.kde.org/kdevplatform/cd3d48751c167ac547682a559e98e7dd7aa425a3

-- 
You are receiving this mail because:
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]