[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 167852] Panels on shared screen edges not included in strut area
From:       Thomas Lübking <thomas.luebking () gmail ! com>
Date:       2012-03-27 22:02:00
Message-ID: bug-167852-17878-cM3YVG5ksN () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=167852

--- Comment #55 from Thomas Lübking <thomas.luebking@gmail.com> ---
Created attachment 69951
  --> https://bugs.kde.org/attachment.cgi?id=69951&action=edit
quick patch to kwin/geometry.cpp

First off all, this:
> KDE3 could gracefully cope with the subject
is complete bull... nonsense.
It did and does work for multiscreen setups and kicker was just *crap* (yes:
*crap* - it's even documented all over kwin comments) regarding xinerama
support (no idea whether xrandr was even ever supported at KDE3 times)

Attached is a patch for geometry.cpp which mostly fixes whitespaces (drove me
complete nuts) and also "prepares" kwin for "correct" multiscreen strutting by
-more or less deviating from the NETWM spec- interpreting struts related to the
strutting window's screen instead of the desktop.

It works fine with my private desktop shell, but it does NOT work with
plasma-desktop, because in screen panels simply don't set struts.

The relevant change is to *move* positions instead of setting them (usually
resulting in negative strut rects)

@Martin:
the patch is more or less a hack on what's there, eg this 
    // HACK: workarea handling is not xinerama aware, so if this strut
    // reserves place at a xinerama edge that's inside the virtual screen,
    // ignore the strut for workspace setting.
    if (area == Kephal::ScreenUtils::desktopGeometry()) {
is ridiculous - ::adjustedClientArea() is only used in geometry.cpp - in case
plasma-desktop / panel containments ever gets this kind of strutting, please
ask back for proper patch

-- 
You are receiving this mail because:
You are watching all bug changes.=
[prev in list] [next in list] [prev in thread] [next in thread]