[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 260586] JJ: remove QPointer usage, port to QWeakPointer
From:       Milian Wolff <mail () milianw ! de>
Date:       2010-12-27 13:29:14
Message-ID: 20101227132914.51EDC78E56 () immanuel ! kde ! org
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=260586





--- Comment #5 from Milian Wolff <mail milianw de>  2010-12-27 14:29:13 ---
please Nathanael and anyone else interested, please use reviewboard to send in
patches:

http://git.reviewboard.kde.org

Some notes on your patch already:

- it shows that in GDB the pointer was used quite a lot without being checked,
you should do that at the start of each function, or at least Q_ASSERT on it.
- +    handler_this.clear(); in the ctor doesn't make any sense, just leave it
out, the QWeakPointer ctor will init itself properly

and of course we need to test it :) Thanks already

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]