[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 257058] cannot write audio CD, "Error while decoding audio
From:       cedric <cedric.borgese () gmail ! com>
Date:       2010-12-05 23:24:20
Message-ID: 20101205232420.C4EC47694B () immanuel ! kde ! org
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=257058


cedric <cedric.borgese@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #4 from cedric <cedric borgese gmail com>  2010-12-06 00:24:17 ---
commit 92ff174b2e7be1a3402ab573567be272ebc2400c
branch master
Author: Cédric Borgese <cedric.borgese@gmail.com>
Date:   Mon Dec 6 00:14:29 2010 +0100

    Don't read from the track reader when it's in "at end" state to avoid false
error notification. Thanks to Cédric Borgese for a patch!
    BUG: 257058
    CCMAIL: cedric.borgese@gmail.com

diff --git a/libk3b/projects/audiocd/k3baudioimager.cpp
b/libk3b/projects/audiocd/k3baudioimager.cpp
index 75186b7..0fa5c9d 100644
--- a/libk3b/projects/audiocd/k3baudioimager.cpp
+++ b/libk3b/projects/audiocd/k3baudioimager.cpp
@@ -117,7 +117,7 @@ bool K3b::AudioImager::run()
         //
         // Read data from the track
         //
-        while( (read = trackReader.read( buffer, sizeof(buffer) )) > 0 ) {
+        while( !trackReader.atEnd() && (read = trackReader.read( buffer,
sizeof(buffer) )) > 0 ) {
             if( !d->ioDev ) {
                 waveFileWriter.write( buffer, read,
K3b::WaveFileWriter::BigEndian );
             }

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]