[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 202021] Some ID3 Tags are not displayed (Worked with 2.2-SVN)
From:       Jonah Bernhard <noahsark1126 () gmail ! com>
Date:       2009-09-09 19:07:27
Message-ID: 20090909190727.2C31B1D9CE () immanuel ! kde ! org
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=202021





--- Comment #19 from Jonah Bernhard <noahsark1126 gmail com>  2009-09-09 21:07:22 ---
Ok, I got it.  Here's the output:



59bd5716d56e0b744666e35cfd8be76be37fe84d is the first bad commit
commit 59bd5716d56e0b744666e35cfd8be76be37fe84d
Author: Jeff Mitchell <mitchell@kde.org>
Date:   Fri Jul 17 16:45:01 2009 +0000

    Rework AFT algorithm. For N tracks, this removes N SELECT queries during a
scan. In most cases this will also remove N UPDATE queries per scan, meaning
that on the average case it will eliminate two SQL accesses per scanned track.
(The only time it still uses the UPDATE is when AFT actually kicks in because
of a change.)

    nhn, let me know your scan time with this  :-)

    svn path=/trunk/extragear/multimedia/amarok/; revision=998438

:040000 040000 45a5f5a24f66300a02b12dd830319cd239a782c7
63cb158f30d6307d1f588c2c7e846ce1c1fb12b0 M      src



I should also mention that on the last two bad revisions, amarok actually 
segfaulted on startup.  Here's my git bisect log:



git bisect start
# bad: [6a050584762eefca68b29735ba4a584c1452fa1d] Move own header to the top
git bisect bad 6a050584762eefca68b29735ba4a584c1452fa1d
# good: [2f1bb4954f8c78d133c8db3234763b84494e638b] A pile of work on getting
the amrok url system back up to speed. Change the overall structure of the
urls. This basically means that they are imcompatible with previous versions,
but it should be possible to make a compatability function that can translate
if needed. Still WIP but getting there...
git bisect good 2f1bb4954f8c78d133c8db3234763b84494e638b
# bad: [4996b09de73ed21b673ab95c415372bcb8223ed0] Fix save playlist on exit for
Windows.
git bisect bad 4996b09de73ed21b673ab95c415372bcb8223ed0
# bad: [27ac45720172d931125ab264f70d493d2e12c775] dynamic mysql client library
is called different on windows
git bisect bad 27ac45720172d931125ab264f70d493d2e12c775
# bad: [d5a436b16c6784b76b3bb8b94e55b455a236fdec] If a copy is in progress,
don't start another one. Eventually the interface for queuing tracks to copy
will change, but this will work for now to avoid kabooms and odd behaviors.
git bisect bad d5a436b16c6784b76b3bb8b94e55b455a236fdec
# good: [afccf9a3b5e79213c67be57be7cc047bd8e84e2a] Moved enum
Playlist::DataRoles to PlaylistDefines where it belongs.
git bisect good afccf9a3b5e79213c67be57be7cc047bd8e84e2a
# good: [914292a2698c8fbe198fb6a11cce5c0b0499a49e] Make removing a track from a
playlist using <del> more reliable.
git bisect good 914292a2698c8fbe198fb6a11cce5c0b0499a49e
# bad: [9950b5dc8c182d919a85cb530762ada0b5e72ccb] Make compile on Qt 4.4 BUG:
200609
git bisect bad 9950b5dc8c182d919a85cb530762ada0b5e72ccb
# bad: [cc501a7f161b3e52c27302f65d69bb39131f3a9b] Prefetch albumId at the same
time as other ID values. Depending on circumstances this will reduce up to N
queries for N tracks; average case is highly dependent on the variety of music
in the collection.
git bisect bad cc501a7f161b3e52c27302f65d69bb39131f3a9b
# good: [a170c7794a33cac42be32e7839d217d64a849a9b] This: Reduces the column
size of some columns such that they are indexable even if populated with
multi-byte characters; ensures that all tables are created using MyISAM;
forcefully converts all tables to MyISAM in case some are still sitting around
as InnoDB from a long time ago; updates all indexes to get rid of invalid index
warnings. All of them. Except you may get a bunch of errors in debug as it's
doing conversion.
git bisect good a170c7794a33cac42be32e7839d217d64a849a9b
# bad: [65243e49f90941b586136a5fe0923738da8a4b5a] Made the Playlist::Navigators
use Playlist::GroupingProxy instead of Playlist::Model. For this I also needed
to expose some more methods in Playlist::AbstractModel. Removed
Playlist::FilterProxy::firstMatchAfterActive() and firstMatchBeforeActive()
because they are not needed any more.
git bisect bad 65243e49f90941b586136a5fe0923738da8a4b5a
# bad: [59bd5716d56e0b744666e35cfd8be76be37fe84d] Rework AFT algorithm. For N
tracks, this removes N SELECT queries during a scan. In most cases this will
also remove N UPDATE queries per scan, meaning that on the average case it will
eliminate two SQL accesses per scanned track. (The only time it still uses the
UPDATE is when AFT actually kicks in because of a change.)
git bisect bad 59bd5716d56e0b744666e35cfd8be76be37fe84d

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]