[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 200904] [PATCH] Using KNotification instead of KPassivePopup
From:       Juan Carlos Torres <carlosdgtorres () gmail ! com>
Date:       2009-07-20 18:27:03
Message-ID: 20090720182703.D9F3314718 () immanuel ! kde ! org
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=200904


Juan Carlos Torres <carlosdgtorres@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |carlosdgtorres@gmail.com




--- Comment #2 from Juan Carlos Torres <carlosdgtorres gmail com>  2009-07-20 20:26:56 ---
Thank you very much for the patch. I would just like to point out a few issues
that we encountered while trying to implement this a few months ago.

1. KPassivePopup allowed us to display a notification title and an icon, which
gives context to the popup. KNotification doesn't allow us to set a title. It
does allow us to use a pixmap for the icon, but this is not displayed by the
Plasma-themed notification. Fortunately, KDE 4.3 will allow us to set titles.
And perhaps the problem with displaying pixmaps is fixed in Plasma as well (I
haven't confirmed yet). However, since 4.3 is yet to be released, we cannot yet
rely on those features.

2. A more important blocker is the amount of disruptive changes that will have
to be done if this change to KNotification is introduced. We'd have to add a
new "Configure Notifications" as well as a yakuake.notifyrc file (which must be
filled with entries) just for a single item ("Show startup notification
popup"). Also, the config dialog will have to be changed, and then we'll have
the problem of how to transition the user's setting for the popup to the new
notifyrc. That is, if we default to enabling the popup in the next release but
the user has already disabled it in the current release, upgrading will force
the user to turn it off again.

So at the moment, it's not yet practical for us to switch over to KNotification
just for a single event. We'll probably have more events in the future so we'll
get that done eventually. Thanks again for the contribution and hope to see
more patches. :)

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]