[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 182772] After opening CMake project, state of project options
From:       Andreas Pakulat <apaku () gmx ! de>
Date:       2009-06-03 20:36:54
Message-ID: 20090603203654.834AC16992 () immanuel ! kde ! org
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=182772





--- Comment #6 from Andreas Pakulat <apaku gmx de>  2009-06-03 22:36:47 ---
(In reply to comment #5)
> #1 Apaku, what about showing the create builddir dialog instead of this half
> version?

Please don't :) In fact the run-stuff should be removed from the dialog in the
settings. Instead it should just allow to select a builddir, build type,
additional arguments and cmake binary (maybe also install prefix as convenience
lineedit). Then store those things and create the builddir. After that it
closes itself, showing a nice message that the cmake cache variables will be
shown after the first build of the project has been run. So the user knows he
should close the dialog and run build for the project.

The reason is simply to not have two places that need to know how to execute
cmake (the cmake builder already knows) and to have support for jumping between
cmake errors in the outputview.

> Another option would be to run the CMakeBuilder::configure right after
> configuring the project. Otherwise we get a strange state were we have selected
> the builddir but it doesn't exist yet and the configuration gets messed up.

Why does the configuration get messed up if the builddir exists (I know
mkdir'ing the builddir isn't done right now) but doesn't contain cmake files?
We should be able to handle that case.

> Actually I think that there should be only 1 way to configure build
> directories, I can fix that but I'd like to know what you think about the
> proper way to do it first.

Well, just one dialog that behaves the same in all situations and the action to
actually configure is "Configure" in the Project menu. 
Regarding the initial configuration of a new project I see two other ways to do
it than the modal dialog that currently pops up:

a) provide a way for any plugin to supply wizard pages to the appwizard and
hence allow an optional cmake page for cmake projects to configure these things
(using the same widget as in the project config dialog)

b) always use build subdir in the project and system cmake

I'd favor option a) actually. Oh and ideally we wouldn't have a second dialog
on top of the project settings, instead have it all in one - somehow :)

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]