[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 66492] keuphoria occasionally only using quarter of screen
From:       Oswald Buddenhagen <ossi () kde ! org>
Date:       2009-04-01 9:19:48
Message-ID: 20090401091948.30173159D6 () immanuel ! kde ! org
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=66492





--- Comment #35 from Oswald Buddenhagen <ossi kde org>  2009-04-01 11:19:43 ---
that one is technically correct. there is still room for improvement, though:
:)

i don't think you need to include QResizeEvent.
there is a resize() overload which takes a QSize.
trivial constructors of private classes are typically inlined.
the creation of the private object is typically put into the c'tor's variable
initializer list (i.e., before the opening brace).
you are leaking the private object.
given that the private object contains exactly one pointer, it might be
preferable to replace the unused d pointer with that one, adding a big fat note
that if more members are added, they need to be moved to a private object.
make a line break after the if's condition.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]