[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 177807] Dolphin's places toolbar new behaviour
From:       Christoph Feck <christoph.feck () mathe-kapiert ! de>
Date:       2009-01-18 2:54:38
Message-ID: 20090118025438.1CA7413FE5 () immanuel ! kde ! org
[Download RAW message or body]

http://bugs.kde.org/show_bug.cgi?id=177807


Peter Penz peter penz gmx at changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

Christoph Feck christoph feck mathe-kapiert de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |christoph.feck@mathe-
                   |                            |kapiert.de
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |




--- Comment #4 from Peter Penz <peter penz gmx at>  2008-12-16 13:07:12 ---
SVN commit 897524 by ppenz:

During the improvements to embed the capacity bar for external devices the
vertical margin between items got lost. See bug 177807 for details:

CCMAIL: ervin@kde.org
BUG: 177807

 M  +2 -2      kfileplacesview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=897524


--- Comment #5 from Christoph Feck <christoph feck mathe-kapiert de>  2009-01-18 03:54:37 ---
Peter, let me explain why the spacing of items changed.

The reason is that KDialog::marginHint() changed its implementation. Before, it
returned a fixed value of 9. Now it returns the style's PM_DefaultChildMargin,
which is 4 with Oxygen. That's why you needed to double its value to get the
old behaviour back. But this makes it too big with other styles, such as
Plastique.

The KDialog::marginHint() is actually supposed to return
PM_DefaultTopLevelMargin, because dialogs usually are top level windows. But I
opted for the child margin value, because existing users of the call are likely
using its return value for child margins inside a dialog.

Maybe you shouldn't use KDialog::marginHint() at all (it's deprecated), and
just adapt margins to font size, so you could add "option.fontMetrics.height()
/ 2" instead of "2 * KDialog::marginHint()" for additional margins. This makes
spacing independent of style, and be visually pleasing with any font size.

I reopened the bug because of the Plastique problem.


-- 
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]