[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 170147] kded4 crashes if a local page tries to store a cookie
From:       Michael Pyne <mpyne () purinchu ! net>
Date:       2008-08-31 22:49:06
Message-ID: 20080831224906.EAD3E12DCF () immanuel ! kde ! org
[Download RAW message or body]

http://bugs.kde.org/show_bug.cgi?id=170147


Michael Pyne mpyne purinchu net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mpyne@purinchu.net




--- Comment #2 from Michael Pyne <mpyne purinchu net>  2008-09-01 00:49:04 ---
The obvious fix is a patch like this (in kdelibs/kioslave/http/kcookiejar):

Index: kcookiejar.cpp
===================================================================
--- kcookiejar.cpp      (revision 854524)
+++ kcookiejar.cpp      (working copy)
@@ -516,7 +516,7 @@
    extractDomains(_fqdn, domains);
    if (domains.count() > 3)
       _domain = domains[3];
-   else
+   else if (!domains.isEmpty())
       _domain = domains[0];
 }

to check if the domains list is empty.  That relies on the rest of KCookieJar
being able to cope with that.  Judging from the code I was reading and the test
I did it seems KCookieJar can cope with that.

That still leaves the question of why is it this only happens if the page is
saved locally though.  I do know that a local CGI script does not cause this
crash using the set-cookie: http header.  I haven't tried reproducing the
testcase html on a remote server however.


-- 
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]