[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 162546] crash (assert failure) doing undo+redo
From:       Dominik Haumann <dhdev () gmx ! de>
Date:       2008-07-16 21:34:07
Message-ID: 20080716213407.13916.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
         
http://bugs.kde.org/show_bug.cgi?id=162546         




------- Additional Comments From dhdev gmx de  2008-07-16 23:33 -------
SVN commit 833482 by dhaumann:

Changes include
- the undo cursor and undo selection are saved with the first
  KateDocument::editStart()
- the redo cursor and redo selection are saved with the last
  KateDocument::editEnd()

For this to work, the following parts needed to be fixed
- wrap doDeleteWordLeft/Right with editStart() and editEnd(),
  otherwise wordLeft() and wordRight() change the cursor position
- drag & drop: while moving the cursor position is changed. To
  make it work, we need to fix the cursor position before we really
  do the drop operation. The undo selection is only set in the case
  of a move, otherwise it does not make sense (it feels really strange)

Please test the patch, as it should go into KDE 4.1 if it works. Right now, 
the KDE 4.1 branch crashes sometimes when doing undo/redo.

Port to KDE 4.1.0? Wait for KDE 4.1.1? dunno...

CCBUG: 162546


 M  +9 -5      document/katedocument.cpp  
 M  +34 -16    document/kateundo.cpp  
 M  +28 -6     document/kateundo.h  
 M  +27 -14    view/kateviewinternal.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=833482
[prev in list] [next in list] [prev in thread] [next in thread]