[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 158377] digikam duplicates downloaded images while overwriting
From:       David Fraser <davidf () sjsoft ! com>
Date:       2008-03-03 15:59:16
Message-ID: 20080303155916.22535.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
         
http://bugs.kde.org/show_bug.cgi?id=158377         




------- Additional Comments From davidf sjsoft com  2008-03-03 16:59 -------
Tested and it at least works... I would recommend that this be used as a band-aid \
patch though. The problem with the current system is that if the final rename fails, \
the picture has not been copied correctly, but there is no good way to recover this. \
It seems that the rename was moved into the event handling section so that there \
could be GUI interaction to change the name. Things that would improve this:
 * If the rename fails, a dialog should be created just like if the copy fails.(It is \
not expected to fail because the target file is checked, but as this error shows it \
                can fail in other ways)
 * If the rename fails, then using "Download/Delete" should NOT delete images that \
weren't copied successfully... so the deleteAfter in slotDownload should ignore \
                failed images
 * There should be options to "Select Failed" images and to "Delete successfully \
                copied images"
 * There should be at least a sanity check when deleting to ensure that the target \
deleted image is the same file size etc as the source image, and big error dialogs \
should pop up if this is not the case :-)


[prev in list] [next in list] [prev in thread] [next in thread]