[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konq-bugs
Subject:    [Bug 149018] Links are unresponsive when they have { visibility:
From:       Germain Garand <germain () ebooksfrance ! com>
Date:       2007-09-11 21:48:26
Message-ID: 20070911214826.24084.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=149018         




------- Additional Comments From germain ebooksfrance com  2007-09-11 23:48 \
                -------
-    if (/*hitTestAction != HitTestChildrenOnly &&*/ !inside && \
style()->visibility() != HIDDEN) { +    if (/*hitTestAction != \
HitTestChildrenOnly &&*/ !inside ) {

yes indeed, visibility is tested at the linebox level now (e.g in \
InlineFlowBox::nodeAtPoint). It's a left over from how we did hit test \
before so it should be removed as well as the commented pieces (very \
untidy... must have forgot to clean that file before commit).

-    if (inside && element()) {
+    if (inside && element() && style()->visibility() != HIDDEN) {

I hope we can soon remove this trailing block making post-hittest \
corrections (also the same is present in RenderText). I never quite \
understood what they were supposed to fix (inline blocks unduly stealing \
the inner node? mmh). They came from WC, and WC got rid of them eventually.

> The problem is that lines are not hittest when inlines are hidden. This 
> actually looks like a regression, since the commented code above would \
> have  been working. Germain? 

yes, if visibility was handled in the corresponding \
Render{Text/Image/etc.}::nodeAtPoint, it was probably working.

IIRC, overiding visibility from hidden to visible in children doesn't work \
everywhere (cf. wrong optimization in RenderLayer). \
_______________________________________________ Konq-bugs mailing list
Konq-bugs@mail.kde.org
https://mail.kde.org/mailman/listinfo/konq-bugs


[prev in list] [next in list] [prev in thread] [next in thread]