[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 130588] Ambiguous meaning of 320 numerical causing erroneous
From:       Peter Simonsson <peter.simonsson () gmail ! com>
Date:       2007-07-22 10:50:05
Message-ID: 20070722105005.10446.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
         
http://bugs.kde.org/show_bug.cgi?id=130588         




------- Additional Comments From peter.simonsson gmail com  2007-07-22 12:50 -------
SVN commit 690835 by psn:

Let's treat 307 and 320 equally until we decide what to do with 320
CCBUG:130588


 M  +1 -12     inputfilter.cpp  
 M  +1 -1      ircview.h  


--- branches/extragear/kde3/network/konversation/src/inputfilter.cpp #690834:690835
 @ -1210,6 +1210,7  @
             }
             // From a WHOIS.
             //[19:11] :zahn.freenode.net 320 PhantomsDad psn :is an identified user
+            case RPL_WHOISIDENTIFY:
             case RPL_IDENTIFIED:
             {
                 NickInfo* nickInfo = server->getNickInfo(parameterList[1]);
 @ -1423,18 +1424,6  @
                 }
                 break;
             }
-            case RPL_WHOISIDENTIFY:
-            {
-                // Display message only if this was not an automatic request.
-                if(getAutomaticRequest("WHOIS",parameterList[1])==0)
-                {
-                    server->appendMessageToFrontmost(i18n("Whois"),
-                        i18n("%1 has identified for this nick.")
-                        .arg(parameterList[1])
-                        );
-                }
-                break;
-            }
             case RPL_WHOISHELPER:
             {
                 // Display message only if this was not an automatic request.
--- branches/extragear/kde3/network/konversation/src/ircview.h #690834:690835
 @ -73,7 +73,7  @
 
         void setNickAndChannelContextMenusEnabled(bool enable);
 
-        signals:
+    signals:
         // Notify container of new text and highlight state
         void updateTabNotification(Konversation::TabNotifyType type);
         void gotFocus();                          // So we can set focus to input line
[prev in list] [next in list] [prev in thread] [next in thread]