[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 147029] crash opening c++ project
From:       Andreas Pakulat <apaku () gmx ! de>
Date:       2007-07-04 11:51:13
Message-ID: 20070704115113.3847.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
         
http://bugs.kde.org/show_bug.cgi?id=147029         
apaku gmx de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From apaku gmx de  2007-07-04 13:51 -------
SVN commit 683216 by apaku:

Empty QStrings in filelists obviously cause problems, make sure we never emit a
signal with an empty QString in a list and we ignore empty lines in the
.filelist file.
Thanks to Rob L. for investigating and finding the problem.
BUG:147029


 M  +3 -1      customprojectpart.cpp  


--- branches/KDE/3.5/kdevelop/buildtools/custommakefiles/customprojectpart.cpp \
#683215:683216  @ -439,7 +439,7  @
         while ( !stream.atEnd() )
         {
             QString s = stream.readLine();
-            if ( !s.startsWith( "#" ) && QFileInfo( projectDirectory() + "/" + s \
).exists() && m_sourceFiles.find(s) == m_sourceFiles.end() ) +            if ( \
!s.isEmpty() && !s.startsWith( "#" ) && QFileInfo( projectDirectory() + "/" + s \
).exists() && m_sourceFiles.find(s) == m_sourceFiles.end() )  {
                 if( isInBlacklist(s) )
                     continue;
 @ -684,6 +684,7  @
     QStringList myfileList = fileList;
     kdDebug(9025) << "Adding files: " << myfileList << endl;
     myfileList.remove(".");
+    myfileList.remove("");
     myfileList.remove("..");
     for ( it = myfileList.begin(); it != myfileList.end(); ++it )
     {
 @ -761,6 +762,7  @
     QStringList::ConstIterator it;
     myfileList.remove(".");
     myfileList.remove("..");
+    myfileList.remove("");
 
     for ( it = myfileList.begin(); it != myfileList.end(); ++it )
     {


[prev in list] [next in list] [prev in thread] [next in thread]