[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 143977] Stepping in debugger too slow
From:       Thomas McGuire <Thomas.McGuire () gmx ! net>
Date:       2007-04-19 14:11:19
Message-ID: 20070419141119.32646.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
         
http://bugs.kde.org/show_bug.cgi?id=143977         




------- Additional Comments From Thomas.McGuire gmx net  2007-04-19 16:11 -------
SVN commit 655835 by tmcguire:

Revert my commit 652655.
This needs a more sophisticated approach.
Current problems:
- Sometimes the framestack widget is shown when the debugger is not running, then \
                tries to update which will not work and show an error message
- The framestack widget is sometimes updated even when the program state did not \
change, for example when switching tabs. This causes the widget to be reset, which \
will lose all custom expanded frames.

CCBUG: 143977

 M  +0 -17     framestackwidget.cpp  
 M  +0 -1      framestackwidget.h  


--- branches/KDE/3.5/kdevelop/languages/cpp/debugger/framestackwidget.cpp \
#655834:655835  @ -128,12 +128,6  @
 
 void FramestackWidget::slotEvent(GDBController::event_t e)
 {
-    //We do not update the frame stack widget if it is not visible.
-    //This saves some time when stepping in/over, as unnecessary 
-    //GDB commands are avoided.
-    if (!isVisible())
-        return;
-
     switch(e)
     {
         case GDBController::program_state_changed: 
 @ -473,17 +467,6  @
     p->fillRect(section1, KGlobalSettings::alternateBackgroundColor());
 }
 
-
-void FramestackWidget::showEvent ( QShowEvent *event )
-{
-    QListView::showEvent( event );
-
-    //Because this widget was hidden before, its state is out of date.
-    //Force an update by sending the appropriate events.
-    slotEvent( GDBController::program_state_changed );
-    slotEvent( GDBController::thread_or_frame_changed );
-}
-        
 // **************************************************************************
 // **************************************************************************
 // **************************************************************************
--- branches/KDE/3.5/kdevelop/languages/cpp/debugger/framestackwidget.h \
#655834:655835  @ -112,7 +112,6  @
     void drawContentsOffset( QPainter * p, int ox, int oy,
                              int cx, int cy, int cw, int ch );
 
-    void showEvent ( QShowEvent *event );
 
 
 private:


[prev in list] [next in list] [prev in thread] [next in thread]