[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 140881] Karm should deal more gracefully with stale lock files
From:       Tim Small <tim () buttersideup ! com>
Date:       2007-01-31 12:04:47
Message-ID: 20070131120447.8108.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
         
http://bugs.kde.org/show_bug.cgi?id=140881         




------- Additional Comments From tim buttersideup com  2007-01-31 13:04 -------
Before I nuked my stale lock files, I created this archive:

cpio -tv  < ~/karm.cpio
-rw-------   1 tim      tim           361 Jan 30 09:14 .kde/share/config/karmrc
-rw-------   1 tim      tim           121 Jan 29 21:35 \
.kde/share/config/session/karm_1013714bdfde000116983195400000029880007_1170106533_180931
 drwx------   2 tim      tim             0 Jan 26 18:18 .kde/share/apps/karm
-rw-r--r--   1 tim      tim             0 Jan 26 18:18 .kde/share/apps/karm/karm.ics~
-rw-r--r--   1 tim      tim          4447 Jan 26 18:13 .kde/share/apps/karm/karm.ics
-rw-r--r--   2 tim      tim             0 Jan 26 18:18 \
                .kde/share/apps/kabc/lock/_home_tim_.kde_share_apps_karm_karm.ics.lock
                
-rw-r--r--   2 tim      tim             0 Jan 26 18:18 \
.kde/share/apps/kabc/lock/_home_tim_.kde_share_apps_karm_karm.icsiobThQSo

..  If I now:

touch .kde/share/apps/kabc/lock/_home_tim_.kde_share_apps_karm_karm.ics.lock

I can reproduce the "could not save" message.  This file name corresponds to the path \
to the actual ics file i.e. the '/'s are replaced with '_'s

This doesn't seem to be a very clever lock file, as it is just an empty file, and \
doesn't contain any info (e.g. PID of process which created the lock).  Maybe this \
lock file was truncated, or something?

3.2-api/kabc/html/lock_8cpp-source.html

There does seem to be some code here to override stale locks?  Maybe there is a bug \
in kabc (which should just call lockf() to let the OS take care of locks, where \
available, rather than reimplementing it in userspace!), but in any case, I think \
that Karm should handle it better (e.g. complain loudly at the beginning of the \
session, or when the timer is started - which would imply attempting a write when the \
session is started).


[prev in list] [next in list] [prev in thread] [next in thread]