[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 139378] Build options run directory textbox does not
From:       Andreas Pakulat <apaku () gmx ! de>
Date:       2006-12-31 10:28:48
Message-ID: 20061231102848.2135.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
         
http://bugs.kde.org/show_bug.cgi?id=139378         
apaku gmx de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From apaku gmx de  2006-12-31 11:28 -------
SVN commit 618132 by apaku:

Use a URL Requester for the build path to be consistent with other parts of kdevelop.
BUG:139378


 M  +3 -2      custombuildoptionswidget.cpp  
 M  +26 -16    custombuildoptionswidgetbase.ui  


--- branches/kdevelop/3.4/buildtools/custommakefiles/custombuildoptionswidget.cpp #618131:618132
 @ -13,6 +13,7  @
 
 #include <qcheckbox.h>
 #include <klineedit.h>
+#include <kurlrequester.h>
 #include <qradiobutton.h>
 #include <qtabwidget.h>
 #include "domutil.h"
 @ -24,7 +25,7  @
       m_dom(dom)
 {
     ant_button->setChecked(DomUtil::readEntry(dom, "/kdevcustomproject/build/buildtool") == "ant");
-    builddir_edit->setText(DomUtil::readEntry(dom, "/kdevcustomproject/build/builddir"));
+    builddir_edit->setURL(DomUtil::readEntry(dom, "/kdevcustomproject/build/builddir"));
 
     // This connection must not be made before the ant->setChecked() line,
     // because at this time makeToggled() would crash
 @ -41,7 +42,7  @
 {
     QString buildtool = ant_button->isChecked()? "ant" : "make";
     DomUtil::writeEntry(m_dom, "/kdevcustomproject/build/buildtool", buildtool);
-    DomUtil::writeEntry(m_dom, "/kdevcustomproject/build/builddir", builddir_edit->text());
+    DomUtil::writeEntry(m_dom, "/kdevcustomproject/build/builddir", builddir_edit->url());
 }
 
 
--- branches/kdevelop/3.4/buildtools/custommakefiles/custombuildoptionswidgetbase.ui #618131:618132
 @ -1,4 +1,4  @
-<!DOCTYPE UI><UI version="3.0" stdsetdef="1">
+<!DOCTYPE UI><UI version="3.3" stdsetdef="1">
 <class>CustomBuildOptionsWidgetBase</class>
 <widget class="QWidget">
     <property name="name">
 @ -19,7 +19,6  @
         <property name="name">
             <cstring>unnamed</cstring>
         </property>
-
         <widget class="QButtonGroup">
             <property name="name">
                 <cstring>buildtool_group</cstring>
 @ -31,7 +30,6  @
                 <property name="name">
                     <cstring>unnamed</cstring>
                 </property>
-
                 <widget class="QRadioButton">
                     <property name="name">
                         <cstring>make_button</cstring>
 @ -63,13 +61,19  @
             <property name="sizeType">
                 <enum>Minimum</enum>
             </property>
+            <property name="sizeHint">
+                <size>
+                    <width>20</width>
+                    <height>20</height>
+                </size>
+            </property>
         </spacer>
         <widget class="QLabel">
             <property name="name">
                 <cstring>builddir_label</cstring>
             </property>
             <property name="text">
-                <string>Run the build tool in the following &amp;directory:</string>
+                <string>Run the &amp;build tool in the following directory:</string>
             </property>
             <property name="buddy" stdset="0">
                 <cstring>builddir_edit</cstring>
 @ -77,16 +81,12  @
         </widget>
         <widget class="QLayoutWidget">
             <property name="name">
-                <cstring>Layout1</cstring>
+                <cstring>layout2</cstring>
             </property>
             <hbox>
                 <property name="name">
                     <cstring>unnamed</cstring>
                 </property>
-                <property name="margin">
-                    <number>0</number>
-                </property>
-
                 <spacer>
                     <property name="name">
                         <cstring>Spacer38</cstring>
 @ -104,7 +104,7  @
                         </size>
                     </property>
                 </spacer>
-                <widget class="KLineEdit">
+                <widget class="KURLRequester">
                     <property name="name">
                         <cstring>builddir_edit</cstring>
                     </property>
 @ -121,18 +121,28  @
             <property name="sizeType">
                 <enum>Expanding</enum>
             </property>
+            <property name="sizeHint">
+                <size>
+                    <width>20</width>
+                    <height>20</height>
+                </size>
+            </property>
         </spacer>
     </vbox>
 </widget>
-<connections>
-</connections>
+<customwidgets>
+</customwidgets>
+<includes>
+    <include location="global" impldecl="in implementation">kdialog.h</include>
+</includes>
 <slots>
     <slot access="protected">makeToggled(bool)</slot>
 </slots>
-<includes>
-    <include location="global" impldecl="in implementation">kdialog.h</include>
-</includes>
 <layoutdefaults spacing="6" margin="11"/>
 <layoutfunctions spacing="KDialog::spacingHint" margin="KDialog::marginHint"/>
-
+<includehints>
+    <includehint>kurlrequester.h</includehint>
+    <includehint>klineedit.h</includehint>
+    <includehint>kpushbutton.h</includehint>
+</includehints>
 </UI>
[prev in list] [next in list] [prev in thread] [next in thread]