[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 24820] [patch] visited links don't change colour until after
From:       Martin Koller <m.koller () surfeu ! at>
Date:       2006-12-30 16:52:09
Message-ID: 20061230165209.12151.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
         
http://bugs.kde.org/show_bug.cgi?id=24820         
m.koller surfeu at changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From m.koller surfeu at  2006-12-30 17:52 -------
SVN commit 617941 by mkoller:

BUG: 24820

immediately redraw visited links with the respective color when the page
got loaded and inserted into the history


 M  +3 -3      khtml/html/html_documentimpl.cpp  
 M  +1 -0      kparts/historyprovider.cpp  
 M  +5 -0      kparts/historyprovider.h  


--- branches/KDE/3.5/kdelibs/khtml/html/html_documentimpl.cpp #617940:617941
 @ -78,11 +78,11  @
     m_doAutoFill = false;
 
 /* dynamic history stuff to be fixed later (pfeiffer)
-    connect( KHTMLFactory::vLinks(), SIGNAL( inserted( const QString& )),
-             SLOT( slotHistoryChanged() ));
     connect( KHTMLFactory::vLinks(), SIGNAL( removed( const QString& )),
              SLOT( slotHistoryChanged() ));
 */
+    connect( KHTMLFactory::vLinks(), SIGNAL( inserted( const QString& ) ),
+             SLOT( slotHistoryChanged() ));
     connect( KHTMLFactory::vLinks(), SIGNAL( cleared()),
              SLOT( slotHistoryChanged() ));
 }
 @ -222,7 +222,7  @
 
 void HTMLDocumentImpl::slotHistoryChanged()
 {
-    if ( true || !m_render ) // disabled for now
+    if ( !m_render )
         return;
 
     recalcStyle( Force );
--- branches/KDE/3.5/kdelibs/kparts/historyprovider.cpp #617940:617941
 @ -70,6 +70,7  @
 {
     // no need to allocate memory, we only want to have fast lookup, no mapping
     d->dict.replace( item, (void*) 1 );
+    emit inserted( item );
 }
 
 void HistoryProvider::remove( const QString& item )
--- branches/KDE/3.5/kdelibs/kparts/historyprovider.h #617940:617941
 @ -89,6 +89,11  @
      */
     void updated( const QStringList& items );
 
+    /**
+     * Emitted after the item has been inserted
+     */
+    void inserted( const QString& item );
+
 private:
     static HistoryProvider *s_self;
[prev in list] [next in list] [prev in thread] [next in thread]