[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konq-bugs
Subject:    [Bug 134232] New: [patch] crash on
From:       Fredrik Johansson <fredrik () mumme ! se>
Date:       2006-09-17 20:02:19
Message-ID: 20060917220217.134232.fredrik () mumme ! se
[Download RAW message or body]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=134232         
           Summary: [patch] crash on
                    http://jdprofessionaltraining.com/help.htm JS deletes
                    iframe I think
           Product: konqueror
           Version: unspecified
          Platform: Compiled Sources
        OS/Version: Linux
            Status: NEW
          Severity: crash
          Priority: NOR
         Component: khtml part
        AssignedTo: konq-bugs kde org
        ReportedBy: fredrik mumme se


Version:           r585455 kde 3.5 branch (using KDE Devel)
Installed from:    Compiled sources
Compiler:          g++4.0.3 Kubuntu dapper x86_64 
OS:                Linux

I get a crash when I visit http://jdprofessionaltraining.com/help.htm
You have to wait a long time for it to load.

I think what happens is that a iframe is innerHTMLed away before the images is \
loaded.

In any case I did a patch, it seems to work.
I attached it here so people can review it

Index: khtml_part.cpp
===================================================================
--- khtml_part.cpp      (revision 585455)
+++ khtml_part.cpp      (working copy)
 @ -2285,6 +2285,10  @
   //kdDebug(6050) << this << " asks the view to emit completed. pendingAction=" << \
pendingAction << endl;  d->m_view->complete( pendingAction );

+  // this frame might already have been deleted when we get here
+  if(!d || !d->m_view)
+     return;
+
   // find the alternate stylesheets
   QStringList sheets;
   if (d->m_doc)
_______________________________________________
Konq-bugs mailing list
Konq-bugs@mail.kde.org
https://mail.kde.org/mailman/listinfo/konq-bugs


[prev in list] [next in list] [prev in thread] [next in thread]