[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 125761] kmplayer - need dcop call to determine playback state
From:       Koos Vriezen <koos.vriezen () xs4all ! nl>
Date:       2006-04-17 20:19:38
Message-ID: 20060417201938.28689.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
         
http://bugs.kde.org/show_bug.cgi?id=125761         
koos.vriezen xs4all nl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From koos.vriezen xs4all nl  2006-04-17 22:19 -------
SVN commit 530855 by vriezen:

Redo fix r530463, it should trigger on document deferring and not to a 
playable Mrl, because PartBase::pause() calls it on the document. Saves 
adding more postponed events to all kinds of mrls and thus fixing all 
these cases (basically all playlists).
Adding isPlaying DCOP function, use as 
 dcop kmplayer-pid KMediaPlayer pause

BUG: 125761

At your service :-)


 M  +5 -1      kmplayerpartbase.cpp  
 M  +1 -0      kmplayerpartbase.h  


--- trunk/extragear/multimedia/kmplayer/src/kmplayerpartbase.cpp #530854:530855
 @ -817,6 +817,10  @
     m_view->fullScreen ();
 }
 
+KDE_NO_EXPORT bool PartBase::isPlaying () {
+    return playing ();
+}
+
 KAboutData* PartBase::createAboutData () {
     KMessageBox::error(0L, "createAboutData", "KMPlayer");
     return 0;
 @ -1074,7 +1078,7  @
     } else if ((new_state == Node::state_deferred ||
                 (old_state == Node::state_deferred &&
                  new_state > Node::state_deferred)) &&
-            elm == m_player->process ()->mrl ().ptr ()) {
+            elm == m_document.ptr ()) {
         m_player->process ()->pause ();
     }
     if (elm->expose () && (new_state == Node::state_activated ||
--- trunk/extragear/multimedia/kmplayer/src/kmplayerpartbase.h #530854:530855
 @ -177,6 +177,7  @
     virtual unsigned long length (void) const;
 k_dcop:
     void toggleFullScreen ();
+    bool isPlaying ();
 signals:
     void sourceChanged (KMPlayer::Source * old, KMPlayer::Source * nw);
     void sourceDimensionChanged ();
[prev in list] [next in list] [prev in thread] [next in thread]