[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 112141] Scripting interface in Konversation
From:       Anders Lund <anders () alweb ! dk>
Date:       2005-11-06 10:54:44
Message-ID: 20051106105444.29301.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
         
http://bugs.kde.org/show_bug.cgi?id=112141         
anders alweb dk changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From anders alweb dk  2005-11-06 11:54 -------
SVN commit 478258 by alund:

Untranslated error message to inform users that we can't replace newlines.
Dont' attempt to, as it may lead to an infinite loop, again potentially leading to a crash at some point.
BUG:112141


 M  +8 -0      katecmds.cpp  


--- branches/KDE/3.5/kdelibs/kate/part/katecmds.cpp #478257:478258
 @ -373,6 +373,7  @
   // * the existing insertion is fine, including the line calculation.
 
   QStringList patterns = QStringList::split( QRegExp("(^\\\\n|(?![^\\\\])\\\\n)"), find, true );
+
   if ( patterns.count() > 1 )
   {
     for ( uint i = 0; i < patterns.count(); i++ )
 @ -488,6 +489,13  @
   exchangeAbbrevs(replace);
    kdDebug(13025)<< "SedReplace: replace=" << replace.latin1() <<endl;
 
+   if ( find.contains("\\n") )
+   {
+     // FIXME i18n this message (or make it work)
+     msg = "Sorry, but we can't replace newlines (yet)";
+     return false;
+   }
+
   KateDocument *doc = ((KateView*)view)->doc();
   if ( ! doc ) return false;
[prev in list] [next in list] [prev in thread] [next in thread]