[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 109815] CSS Editor can only be invoked once on new files
From:       Mantia Andras <amantia () kde ! org>
Date:       2005-09-14 15:18:10
Message-ID: 20050914151810.12208.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
         
http://bugs.kde.org/show_bug.cgi?id=109815         
amantia kde org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From amantia kde org  2005-09-14 17:18 -------
SVN commit 460635 by amantia:

Jens is right, CSS editor should not be invoked in an empty HTML file.

BUG: 109815

 M  +1 -0      ChangeLog  
 M  +3 -3      src/quanta.cpp  


--- branches/KDE/3.5/kdewebdev/quanta/ChangeLog #460634:460635
 @ -26,6 +26,7  @
         - create empty description files for scripts that don't have one
         - fix loading order of the project view files
         - save the content entered in a new file in the VPL editor [#111278]
+        - do not allow invocation of the CSS editor in an empty non-CSS document \
[#109815]  
  - improvements:
         - md5sum based file changed detection
--- branches/KDE/3.5/kdewebdev/quanta/src/quanta.cpp #460634:460635
 @ -4455,8 +4455,8  @
     }
     delete dlg;
 
-  } else if (!node || fullDocument.isEmpty() ||
-      w->currentDTD(true)->name == "text/css") //empty document or pure CSS file, \
invoke the selector editor +  } else
+  if (!node || w->currentDTD(true)->name == "text/css") 
   {
         kdDebug(24000) << "[CSS editor] This is a pure CSS document";
 
 @ -4513,7 +4513,7  @
     }
     delete dlg;
    } else
-   KMessageBox::sorry(this, i18n("The CSS Editor cannot be invoked here.\nTry to \
invoke it on a tag or on a style section.")); +     KMessageBox::sorry(this, \
i18n("The CSS Editor cannot be invoked here.\nTry to invoke it on a tag or on a style \
section."));  }
 
 /** for <a href=mailto> tag  */


[prev in list] [next in list] [prev in thread] [next in thread]