[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 109836] Add Support for displaying Face: header
From:       Nick Brown <nickbroon () blueyonder ! co ! uk>
Date:       2005-08-21 22:33:42
Message-ID: 20050821223342.20854.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
         
http://bugs.kde.org/show_bug.cgi?id=109836         




------- Additional Comments From nickbroon blueyonder co uk  2005-08-22 00:33 -------
SVN commit 451833 by nickbroon:

Reverting 451500

Please accept my deepest apologies, I only over my KDE inexperience as
an excuse.
I was unaware of the feature freeze.
I had asked for and was given a review on the #kontact irc channel.

I will make the required changes and attach a new patch to bug report
for safe keeping. How do I add something to the feature list for a
future release as I am keen to get this into kmail at some point?

Sorry again.

CCBUG: 109836



 M  +0 -44     headerstyle.cpp  


--- branches/KDE/3.5/kdepim/kmail/headerstyle.cpp #451832:451833
 @ -525,50 +525,6  @
 
     if( photoURL.isEmpty() )
     {
-      // no photo, look for a Face header
-      QString faceheader = message->headerField( "Face" );
-      if ( !faceheader.isEmpty() )
-      {
-	QImage faceimage;
-
-	kdDebug( 5006 ) << "Found Face: header" << endl;
-
-	QCString facestring = faceheader.utf8();
-	// Spec says header should be no longer than 998 bytes
-	if ( facestring.length() < 998 )
-	  {
-	    QByteArray facearray;
-	    KCodecs::base64Decode(facestring, facearray);
-	    
-	    QImage faceimage;
-	    if ( TRUE == faceimage.loadFromData( facearray, "png" ) )
-	      {
-		// Spec says image must be 48x48 pixels
-		if ( (48 == faceimage.width()) && (48 == faceimage.height()) )
-		  {
-		    photoURL = imgToDataUrl( faceimage );
-		    photoWidth = 48;
-		    photoHeight = 48;
-		  }
-		else
-		  {
-		    kdDebug( 5006 ) << "Face: header image is" << faceimage.width() << "by" << \
                faceimage.height() <<"not 48x48 Pixels" << endl;
-		  }
-	      }
-	    else
-	      {
-		kdDebug( 5006 ) << "Failed to load decoded png from Face: header" << endl;
-	      }
-	  }
-	else
-	  {
-	    kdDebug( 5006 ) << "Face: header too long at " << facestring.length() << endl;
-	  }
-      }
-    }
-
-    if( photoURL.isEmpty() )
-    {
       // no photo, look for a X-Face header
       QString xfaceURL;
       QString xfhead = message->headerField( "X-Face" );


[prev in list] [next in list] [prev in thread] [next in thread]