[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 89747] Issues saving new tags with recoded 8bit encoding
From:       "Alexey A.Kiritchun" <kaa () nightmail ! ru>
Date:       2005-04-14 20:15:36
Message-ID: 20050414201536.16189.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
         
http://bugs.kde.org/show_bug.cgi?id=89747         




------- Additional Comments From kaa nightmail ru  2005-04-14 22:15 -------
I tested the the patch from liuspider (with 1.2.3, patch applied cleanly), and it is \
still wrong. Really, it makes matters worse. From the looks of it, it tryes to handle \
the conversion between utf and locale, and it does not do it right. When loading an \
mp3 with v1 tags in 8bit charset, all non-latin1 chars are truncated to '?' (hey, \
that's what one would expect from

-            #define strip( x ) TStringToQString( x ).stripWhiteSpace()
+            #define strip( x ) QString::fromLocal8Bit(TStringToQString( x \
).latin1()).stripWhiteSpace();

so that's just plain wrong). If I edit the tag, then import the song again, it shows \
'?' mixed with some chars my fonts can't handle (I see squares), and the length \
doubles - a clear sign of improper handling of UTF<->8bit manipulation.

Release 1.2.2 (didn't test 1.2.3 before) at least was half-working and had \
'compensating' errors, so I _could_ manage my Russian songs. See below for caveats.

What I need (and I guess a number of other people) is correct working of 'recode \
id3v1 data' setting, and that setting is different from locale. The reason for it is \
my hardware player that assumes cp1251 encoding for Cyrillic (that's what Windows \
uses), but my locale is, of course, ru_RU.UTF-8. 

Release 1.2.2 can read in cp1251 v1 tags, but if I edit them, my player shows \
garbage.

Could you please contact me here or by &lt;kaa at nightmail dot ru&gt; and outline \
the parts of amarok code that deal with tags? I do not really have the time to work \
on amarok, but I bet I'll have some ideas at least.


[prev in list] [next in list] [prev in thread] [next in thread]