[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-bugs-dist
Subject: [Bug 63529] Cut off text in koshell sidebar
From: Sven Lueppken <sven () kde ! org>
Date: 2005-02-18 22:09:20
Message-ID: 20050218220920.11567.qmail () ktown ! kde ! org
[Download RAW message or body]
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
http://bugs.kde.org/show_bug.cgi?id=63529
sven kde org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From sven kde org 2005-02-18 23:09 -------
CVS commit by lueppken:
A few changes to koshell:
- Renamed "Parts" to "Components" in the sidebar. This fixes #65718.
- Using a QSplitter instead of a QHBox makes the sidebar-width configurable. I
think that fixes #63529.
- Adding support for KConfig XT in koshell. It now remembers the last
sidebar-width when the app is started.
Ok'ed by dfaure, more patches to come in the next days :)
BUGS:65718
BUGS:63529
A koshell.kcfg 1.1
A koshellsettings.kcfgc 1.1
M +2 -1 Makefile.am 1.29
M +16 -7 koshell_shell.cc 1.77
M +5 -4 koshell_shell.h 1.30
--- koffice/koshell/Makefile.am #1.28:1.29
@ -6,7 +6,8 @
kdeinit_LTLIBRARIES = koshell.la
bin_PROGRAMS =
-koshell_la_SOURCES = koshell_main.cc koshell_shell.cc
+koshell_la_SOURCES = koshell_main.cc koshell_shell.cc koshellsettings.kcfgc
koshell_la_LDFLAGS = $(all_libraries) -module $(KDE_PLUGIN)
koshell_la_LIBADD = $(LIB_KOFFICEUI)
+kde_kcfg_DATA = koshell.kcfg
METASOURCES = AUTO
--- koffice/koshell/koshell_shell.cc #1.76:1.77
@ -20,8 +20,9 @
*/
-#include <qhbox.h>
+#include <qsplitter.h>
#include <assert.h>
#include "koshell_shell.h"
+#include "koshellsettings.h"
#include <ktempfile.h>
@ -53,11 +54,10 @ KoShellWindow::KoShellWindow()
m_activePage = m_lstPages.end();
- m_pLayout = new QHBox( centralWidget() );
-
+ m_pLayout = new QSplitter( centralWidget() );
m_pKoolBar = new KoKoolBar( m_pLayout );
m_pFrame = new KoShellFrame( m_pLayout );
- m_grpFile = m_pKoolBar->insertGroup(i18n("Parts"));
+ m_grpFile = m_pKoolBar->insertGroup(i18n("Components"));
QValueList<KoDocumentEntry> lstComponents = \
KoDocumentEntry::query(false,QString()); QValueList<KoDocumentEntry>::Iterator it = \
lstComponents.begin(); @ -94,6 +94,8 @ KoShellWindow::KoShellWindow()
//m_pKoolBar->insertGroup("Snippets"); //?
- m_pKoolBar->setFixedWidth( 80 );
- m_pKoolBar->setMinimumHeight( 300 );
+ QValueList<int> list;
+ list.append( KoShellSettings::sidebarWidth() );
+ list.append( this->width() - KoShellSettings::sidebarWidth() );
+ m_pLayout->setSizes( list );
connect( this, SIGNAL( documentSaved() ),
@ -129,4 +131,5 @ KoShellWindow::~KoShellWindow()
setRootDocumentDirect( 0L, QPtrList<KoView>() ); // prevent our parent destructor \
from doing stupid things + saveSettings(); // Now save our settings before exiting
}
@ -560,4 +563,10 @ bool KoShellWindow::saveAllPages()
*/
+void KoShellWindow::saveSettings()
+{
+ KoShellSettings::setSidebarWidth( m_pKoolBar->width() );
+ KoShellSettings::writeConfig();
+}
+
QString KoShellWindow::configFile() const
{
--- koffice/koshell/koshell_shell.h #1.29:1.30
@ -28,5 +28,5 @
#include <qvaluelist.h>
-class QHBox;
+class QSplitter;
class KoKoolBar;
class KoDocumentEntry;
@ -72,4 +72,5 @ protected:
virtual bool openDocumentInternal( const KURL & url, KoDocument * newdoc = 0L );
void closeDocument();
+ void saveSettings();
struct Page
@ -103,5 +104,5 @ protected:
void createShellGUI();
- QHBox *m_pLayout;
+ QSplitter *m_pLayout;
};
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic