[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 98517] immediate crash loading a kig generated .kig file
From:       Dominique Devriese <devriese () kde ! org>
Date:       2005-02-10 14:36:58
Message-ID: 20050210143658.21620.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
         
http://bugs.kde.org/show_bug.cgi?id=98517         
devriese kde org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From devriese kde org  2005-02-10 15:36 -------
CVS commit by domi: 

The rest of a fix for bug #98517.  The problem was that namecalcer's
weren't being saved if they weren't shown on the document.  This fixes
the previous fix to not crash on faulty documents, but give a proper
parser error.  This should permanently fix #98517.  The previous fix
was done in cooperation with Pino Toscano.
 
Fix the ChangeLog to document the previous fix for #98517. 

BUGS:98517


  M +18 -0     ChangeLog   1.223
  M +2 -2      filters/native-filter.cc   1.36


--- kdeedu/kig/ChangeLog  #1.222:1.223
 @ -1,2 +1,12  @
+2005-02-10  Dominique Devriese  <devriese kde org>
+
+        * The rest of a fix for bug #98517.  The problem was that
+        namecalcer's weren't being saved if they weren't shown on the
+        document.  This fixes the previous fix to not crash on faulty
+        documents, but give a proper parser error.  This should
+        permanently fix #98517.
+
+        * Fix this ChangeLog to document the previous fix for #98517.
+
 2005-02-07  Maurizio Paolini <paolini dmf unicatt it>
 
 @ -75,4 +85,12  @
         its vertices
 
+2004-12-30  Dominique Devriese <devriese kde org>
+
+        * Fix for a bug where a name calcer wasn't saved if it was only
+        referred to from the object it is the namecalcer for, and not by
+        its own objectholder.  This commit makes sure that no more such
+        files are generated, and that kig no longer crashes on such
+        files. Thanks to Pino Toscano for help in fixing this. (#98517)
+        
 2004-12-28  Maurizio Paolini <paolini dmf unicatt it>
 

--- kdeedu/kig/filters/native-filter.cc  #1.35:1.36
 @ -554,5 +554,5  @ KigDocument* KigFilterNative::load07( co
           int ncid = tmp.toInt( &ok );
           if ( !ok ) KIG_FILTER_PARSE_ERROR;
-          if ( ncid <= 0 || id > calcers.size() )
+          if ( ncid <= 0 || ncid > calcers.size() )
             KIG_FILTER_PARSE_ERROR;
           if ( ! dynamic_cast<ObjectConstCalcer*>( calcers[ncid-1].get() ) )
[prev in list] [next in list] [prev in thread] [next in thread]