[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 83311] dcopAddMessage doesn't support emails with same subject
From:       Danny Kukawka <danny.kukawka () web ! de>
Date:       2005-01-31 21:42:12
Message-ID: 20050131214212.11691.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
         
http://bugs.kde.org/show_bug.cgi?id=83311         




------- Additional Comments From danny.kukawka web de  2005-01-31 22:42 -------
I wrote a patch for this bug and posted it on KMail developers mailing list [1][2].

I attach the patch (against CVS).

Danny

--------------------------------------
Fixed problems:
- dublicated messages during import
- performance of import 

Change log:
--------------------------------------
KMail:

- fixed dcopAddMessage() in kmail, now messageID is used to find duplicated 
messages (see comment in the patch)
- added new function dcopAddMessage_fastImport() to kmail for much more faster  
import without search for duplicated messages (I didn't integrate this to 
dcopAddMessage() , because maybe other programs use this function.)
- added possibility to destroy the static QStringList (see:  dcopAddMessage()) 
with msgIDs if import finished

-------------------------------------
KMailCVT:

- added checkbox in KSelFilterPageDlg to enable 'remove duplicated messages 
during import'. Now import without check for duplicated messages is default.
- updated all filters in kmailcvt 
- changed name of evolution filter in the filterdialog because the filter only 
support Evolution 1.x
- removed info->alert() if duplicated messages was found, added info for user
how many duplicated messages were not imported 
- fixed info->setOverall() in filter_mbox.* and filter_mailapp.* 
- fixed filecheck in filter_mbox.* and filter_mailapp.* (if 
mbox.open(IO_ReadOnly) failed the filter started import anyway (empty 
messages))

Short little performance benchmark:
-----------------------------------------
- mbox: 11 MB, 2911 messages:
  - 1.) remove duplicate messages [old]: 26 sec
  - 2.) without remove                      [new]: 24 sec 
- mbox: 140 MB, 20514 messages:
  - 1.) 802 sec
  - 2.) 730 sec 
- mbox: 133 MB, 35065 messages:
  - 1.) 1055 sec, 1111 sec
  - 2.) 647 sec, 632 sec      (-38,7 %, -43 %)
--------------------------------------------------

[1] http://article.gmane.org/gmane.comp.kde.devel.kmail/36165 
[2] http://article.gmane.org/gmane.comp.kde.devel.kmail/36168
[prev in list] [next in list] [prev in thread] [next in thread]