[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 77315] Special characters when renaming on certain file
From:       Scott Wheeler <wheeler () kde ! org>
Date:       2004-10-18 13:52:42
Message-ID: 20041018135242.7656.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
        
http://bugs.kde.org/show_bug.cgi?id=77315        




------- Additional Comments From wheeler kde org  2004-10-18 15:52 -------
Ah -- now I see what you're getting at.  Actually you're fixing a different bug from \
the one that's reported here, and that's what was confusing me.  This wishlist item \
is actually in reference to certain characters not working on certain file systems -- \
notably FAT not supporting certain characters and having an option to avoid them.

I thought that you were somehow trying to work around that with your patch, which \
well, couldn't have worked in any sane way.

What you actually fixed is a much more recent bug (which didn't exist when this bug \
was opened) where Frerich mistakenly used the KURL(const QString &) constructor \
incorrectly.  Your patch is more or less functionally equivalent to:

-    return KIO::NetAccess::file_move(KURL(src), KURL(dest));
+    return KIO::NetAccess::file_move(KURL::fromPathOrURL(src), \
KURL::fromPathOrURL(dest));

But I agree that it's cleaner, so I'll now commit it.  Sorry for the mix up -- I was \
still trying to understand how you could be fixing the original bug with the patch \
that you gave.


[prev in list] [next in list] [prev in thread] [next in thread]