[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 82085] crashes using gst output
From:       Michael Pyne <michael.pyne () kdemail ! net>
Date:       2004-09-19 7:41:29
Message-ID: 20040919074129.16557.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
        
http://bugs.kde.org/show_bug.cgi?id=82085        
michael.pyne kdemail net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From michael.pyne kdemail net  2004-09-19 09:41 -------
CVS commit by mpyne: 

Try to fix bug 82085 (JuK crashes using gst output).  I looked around a bit and \
couldn't to find a function in the kde gst bindings to determine whether we had a \
valid player object, which means JuK has to trust the bindings not to crash. :-(

I'll admit that I don't have a installation of gstreamer-0.6 to test this with, but \
the changes are straightforward enough.

CCMAIL:82085-done bugs kde org


  M +6 -0      play.cpp   1.5 [POSSIBLY UNSAFE: qDebug]


--- kdenonbeta/gst/kde/gstplay/play.cpp  #1.4:1.5
 @ -557,5 +557,11  @ bool Play::setAutoForAudioBufferThreaded
 
         audioBin = d->otherElements["audioBin"];
+        if (!audioBin){
+                qDebug("We have no audio bin!\n");
+                return false;
+        }
+
         workThread = (Thread*)d->otherElements["workThread"];
+        Q_ASSERT(workThread);
 
         if (d->autoplugger){


[prev in list] [next in list] [prev in thread] [next in thread]