[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 76412] Completing dialog action does not return to the
From:       David Faure <faure () kde ! org>
Date:       2004-03-08 10:15:23
Message-ID: 20040308101523.9775.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
      
http://bugs.kde.org/show_bug.cgi?id=76412      




------- Additional Comments From faure kde org  2004-03-08 11:15 -------
On Sunday 29 February 2004 14:40, alan chandlerfamily org uk wrote:
> Whilst working on this new document, when ever I call up a dialog box (for instance \
> format page layout) kword brings the older documents window as the highest document \
> window behind the dialog box, so that when the dialog box is dismissed the wrong \
> document is displayed.
This sounds like a KWin bug/misbehavior to me. It doesn't happen here, 
so I guess it was fixed in KWin.

However the cause for this problem is a missing parent widget in the dialog,
which I just fixed for the "page layout" dialog. Any other dialog showing the same \
problem?

> It is even worse than this.  If I call up a dialog box that then calls up a \
> subsidiary dialog box (for instance File/Create Template From Document and then \
> select the "select" button related to the custom picture) when I return from the \
> subsidiary dialog box, the original dialog box is hidden behind the old document \
> window - both giving the impression that both dialogs have been dismissed, but also \
> confusing the user who now can't enter anything into the old document.  It is \
> necessary to manually select the new document to get back to the dialog box.    

That was another missing parent widget - fixed as well.

However I'm sure KWin was improved to handle such cases better, since it
all works fine here. I suggest a kdelibs/kdebase upgrade...



------- Additional Comments From faure kde org  2004-03-08 11:15 -------
CVS commit by faure: 

Pass parent widget to page layout dialog (and to the filedialog from the
template-creation dialog). Should fix 76412... but kwin seems to handle such
cases better nowadays anyway, doesn't it?
CCMAIL: 76412 bugs kde org


  M +4 -4      koPageLayoutDia.cc   1.82
  M +2 -3      koPageLayoutDia.h   1.41
  M +2 -2      koTemplateCreateDia.cc   1.48


--- koffice/lib/kofficeui/koPageLayoutDia.cc  #1.81:1.82
 @ -184,8 +184,8  @ KoPageLayoutDia::~KoPageLayoutDia()
 
 /*======================= show dialog ============================*/
-bool KoPageLayoutDia::pageLayout( KoPageLayout& _layout, KoHeadFoot& _hf, int _tabs, \
KoUnit::Unit& unit ) +bool KoPageLayoutDia::pageLayout( KoPageLayout& _layout, \
KoHeadFoot& _hf, int _tabs, KoUnit::Unit& unit, QWidget* parent )  {
     bool res = false;
-    KoPageLayoutDia *dlg = new KoPageLayoutDia( 0, "PageLayout", _layout, _hf, \
_tabs, unit ); +    KoPageLayoutDia *dlg = new KoPageLayoutDia( parent, "PageLayout", \
_layout, _hf, _tabs, unit );  
     if ( dlg->exec() == QDialog::Accepted ) {
 @ -203,8 +203,8  @ bool KoPageLayoutDia::pageLayout( KoPage
 /*======================= show dialog ============================*/
 bool KoPageLayoutDia::pageLayout( KoPageLayout& _layout, KoHeadFoot& _hf, KoColumns& \
                _cl,
-                                  KoKWHeaderFooter &_kwhf, int _tabs, KoUnit::Unit& \
unit ) +                                  KoKWHeaderFooter &_kwhf, int _tabs, \
KoUnit::Unit& unit, QWidget* parent )  {
     bool res = false;
-    KoPageLayoutDia *dlg = new KoPageLayoutDia( 0, "PageLayout", _layout, _hf, _cl, \
_kwhf, _tabs, unit ); +    KoPageLayoutDia *dlg = new KoPageLayoutDia( parent, \
"PageLayout", _layout, _hf, _cl, _kwhf, _tabs, unit );  
     if ( dlg->exec() == QDialog::Accepted ) {

--- koffice/lib/kofficeui/koPageLayoutDia.h  #1.40:1.41
 @ -137,5 +137,5  @ public:
      *  See constructor for documentation on the parameters
      */
-    static bool pageLayout( KoPageLayout&, KoHeadFoot&, int tabs, KoUnit::Unit& \
unit); +    static bool pageLayout( KoPageLayout&, KoHeadFoot&, int tabs, \
KoUnit::Unit& unit, QWidget* parent = 0 );  
     /**
 @ -143,6 +143,5  @ public:
      *  See constructor for documentation on the parameters
      */
-    static bool pageLayout( KoPageLayout&, KoHeadFoot&, KoColumns&, \
                KoKWHeaderFooter&, int tabs, KoUnit::Unit& unit );
-
+    static bool pageLayout( KoPageLayout&, KoHeadFoot&, KoColumns&, \
KoKWHeaderFooter&, int tabs, KoUnit::Unit& unit, QWidget* parent = 0 );  /**
      *  Retrieves a standard page layout.

--- koffice/lib/kofficeui/koTemplateCreateDia.cc  #1.47:1.48
 @ -330,5 +330,5  @ void KoTemplateCreateDia::slotSelect() {
     d->m_custom->setChecked(true);
 
-    KFileDialog fd(QString::null, KImageIO::pattern(KImageIO::Reading), 0, 0, true);
+    KFileDialog fd(QString::null, KImageIO::pattern(KImageIO::Reading), this, 0, \
true);  fd.setCaption(i18n("Select Picture"));
     KURL url;


[prev in list] [next in list] [prev in thread] [next in thread]