[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 73108] kopete crashes when deleting a folder which contains
From:       Matt Rogers <matt.rogers () kdemail ! net>
Date:       2004-02-28 23:05:26
Message-ID: 20040228230526.10660.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
      
http://bugs.kde.org/show_bug.cgi?id=73108      




------- Additional Comments From matt.rogers kdemail net  2004-02-29 00:05 -------
CVS commit by mattr: 

Store the group name in the YahooContact object. Prevents crashes when
deleting a folder which contains offline yahoo contacts. Fixes bug 73108

CCMAIL: 73108 bugs kde org


  M +3 -1      yahoocontact.cpp   1.66
  M +10 -1     yahoocontact.h   1.41


--- kdenetwork/kopete/protocols/yahoo/yahoocontact.cpp  #1.65:1.66
 @ -42,4 +42,6  @ YahooContact::YahooContact( YahooAccount
 
         m_userId = userId;
+        if ( metaContact )
+                m_groupName = metaContact->groups().getFirst()->displayName();
         m_manager = 0L;
         m_account = account;
 @ -169,5 +171,5  @ void YahooContact::slotDeleteContact()
         //my ugliest hack yet. how many levels of indirection do I want? ;)
         if ( m_account->isConnected() )
-                m_account->yahooSession()->removeBuddy(m_userId, \
metaContact()->groups().getFirst()->displayName()); +                \
m_account->yahooSession()->removeBuddy(m_userId, m_groupName);  
         KopeteContact::slotDeleteContact();

--- kdenetwork/kopete/protocols/yahoo/yahoocontact.h  #1.40:1.41
 @ -36,6 +36,7  @ class YahooContact : public KopeteContac
 public:
         YahooContact( YahooAccount *account, const QString &userId, const QString \
                &fullName, KopeteMetaContact *metaContact );
-
         ~YahooContact();
+
+        /** Base Class Reimplementations **/
         virtual bool isOnline() const;
         virtual bool isReachable();
 @ -46,4 +47,9  @ public:
         void setYahooStatus( const KopeteOnlineStatus& );
 
+        /** The group name getter and setter methods**/
+        QString group() const;
+        void setGroup( const QString& );
+
+
 public slots:
         virtual void slotUserInfo();
 @ -66,4 +72,7  @ private:
         QString m_userId;
 
+        //the group name of the contact
+        QString m_groupName;
+
         //The message manager
         KopeteMessageManager *m_manager;


[prev in list] [next in list] [prev in thread] [next in thread]