[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 72917] UTF8 and other cause XML parsing errors,
From:       Martijn Klingens <klingens () kde ! org>
Date:       2004-01-23 16:39:44
Message-ID: 20040123163944.27749.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
      
http://bugs.kde.org/show_bug.cgi?id=72917      




------- Additional Comments From klingens@kde.org  2004-01-23 17:39 -------
Subject: Re: [Kopete-devel]  UTF8 and other cause XML parsing errors, only in IRC conversations

On Friday 23 January 2004 17:27, Jason Keirstead wrote:
> Yes it would be a reasulable first check. If that fails there is no point
> trying to attempt the XML transform.

That, too. But I was thinking of a much earlier stage: when you are parsing 
incoming IRC data and when Oscar is parsing incoming ICQ data.

If isUtf8() fails it can try ::fromLatin1 because that one AFAIK can be 
reliably autodetected (unlike utf8() it doesn't accept invalid chars AFAIK), 
followed by your fallback.

A simple static in libkopete (QString
KopeteMessage::detectEncoding( char * ) ?) could handle it, and avoid the 
problem altogether.

> Note that the reason we didn't use that in Kopete yet is it is an
> @Since 3.2 method

True, it wouldn't help KDE 3.1 users. But #ifdef'd out it would tremendously 
help those who will be upgrading to 3.2. And it allows us to tell users to 
upgrade KDE rather than telling them we can't fix the bug. Lastly, we could 
even duplicate the call in compat/ though I'm not too much in favour of that.
[prev in list] [next in list] [prev in thread] [next in thread]