[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 70937] New: Erroneous play queue flow control
From:       Benedikt Gollatz <benedikt () gollatz ! net>
Date:       2003-12-20 20:57:38
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
     
http://bugs.kde.org/show_bug.cgi?id=70937     
           Summary: Erroneous play queue flow control
           Product: noatun
           Version: unspecified
          Platform: Compiled Sources
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: split
        AssignedTo: charles@kde.org
        ReportedBy: benedikt@gollatz.net


Version:            (using KDE Devel)
Installed from:    Compiled sources
Compiler:          gcc (GCC) 3.3.1 
OS:          Linux

Splitplaylist acts unexpected in a few cases.

First, when hitting "back" it jumps to the file above and plays it regardless of \
whether it isOn() or not. This can easily be corrected by adding three lines to \
playlist.cpp:

--- kdemultimedia/noatun/modules/splitplaylist/playlist.cpp	2003-11-16 \
                21:42:37.000000000 +0100
+++ kdemultimedia/noatun/modules/splitplaylist/playlist.cpp	2003-12-20 \
21:44:41.000000000 +0100 @@ -144,4 +144,8 @@
 
 	setCurrent(nextItem);
+	
+	if (currentItem)
+		if (!static_cast<SafeListViewItem*>(currentItem.data())->isOn())
+			return previous();
 
 	return currentItem;

The problem with this is, that the playlist does not loop backwards.

Additionally, when leaving the last item of the playlist unchecked, Splitplaylist \
loops to the first checked file but plays the last (unchecked) file on the list.


[prev in list] [next in list] [prev in thread] [next in thread]