[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 69133] Kmail crashes when using "save as distribution list"
From:       Tobias "König" <tokoe () kde ! org>
Date:       2003-12-06 15:54:03
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
     
http://bugs.kde.org/show_bug.cgi?id=69133     
tokoe@kde.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From tokoe@kde.org  2003-12-06 16:54 -------
Subject: kdepim/libkdepim

CVS commit by tokoe: 

Fixing two bugs:

1) The crash mentioned in #69133
2) Return only the to-, cc-, bcc-specific distribution lists
   in AddressesDialog::allDistributionLists()

CCMAIL:69133-done@bugs.kde.org


  M +7 -8      addressesdialog.cpp   1.22


--- kdepim/libkdepim/addressesdialog.cpp  #1.21:1.22
@@ -360,4 +360,5 @@ AddressesDialog::updateAvailableAddresse
 {
   d->ui->mAvailableView->clear();
+  d->groupDict.clear();
 
   static const QString &personalGroup = KGlobal::staticQString( i18n( "Other Addresses" ) );
@@ -474,6 +475,5 @@ AddressesDialog::initConnections()
   connect( d->ui->mSelectedView, SIGNAL(doubleClicked(QListViewItem*)),
            SLOT(removeEntry()) );
-/* FIXME: I'm not sure what's going on here, but this code suddenly crashes :/
-          Did somebody changed the KDirWatcher stuff during the last weeks?
+
   connect( KABC::DistributionListWatcher::self(), SIGNAL( changed() ),
            this, SLOT( updateAvailableAddressees() ) );
@@ -481,5 +481,4 @@ AddressesDialog::initConnections()
   connect( KABC::StdAddressBook::self(), SIGNAL( addressBookChanged(AddressBook*) ),
            this, SLOT( updateAvailableAddressees() ) );
-*/
 }
 
@@ -755,4 +754,5 @@ AddressesDialog::saveAs()
                                     "already exists. Please select a different name.</qt>" )
                               .arg( name ) );
+    return;
   }
 
@@ -858,11 +858,10 @@ AddressesDialog::allDistributionLists( A
     return QStringList();
 
-  QListViewItemIterator it( parent );
-  while ( it.current() ) {
-    AddresseeViewItem *item = static_cast<AddresseeViewItem*>( it.current() );
-    if ( item && item->category() == AddresseeViewItem::DistList && !item->name().isEmpty() )
+  AddresseeViewItem *item = static_cast<AddresseeViewItem*>( parent->firstChild() );
+  while ( item ) {
+    if ( item->category() == AddresseeViewItem::DistList && !item->name().isEmpty() )
       lists.append( item->name() );
 
-    ++it;
+    item = static_cast<AddresseeViewItem*>( item->nextSibling() );
   }
[prev in list] [next in list] [prev in thread] [next in thread]