[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 67568] DAV request not re-sent on redirection
From:       Laurence Anderson <l.d.anderson () warwick ! ac ! uk>
Date:       2003-11-11 20:28:26
[Download RAW message or body]

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
     
http://bugs.kde.org/show_bug.cgi?id=67568     
l.d.anderson@warwick.ac.uk changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From l.d.anderson@warwick.ac.uk  2003-11-11 21:28 -------
Subject: kdelibs/kio/kio

CVS commit by landers: 

Re-send DAV request on redirect

CCMAIL:67568-close@bugs.kde.org


  M +16 -2     davjob.cpp   1.11
  M +2 -1      davjob.h   1.6


--- kdelibs/kio/kio/davjob.cpp  #1.10:1.11
@@ -43,7 +43,14 @@
 using namespace KIO;
 
+class DavJob::DavJobPrivate
+{
+public:
+  QByteArray savedStaticData;
+};
+
 DavJob::DavJob( const KURL& url, int method, const QString& request, bool showProgressInfo )
   : TransferJob( url, KIO::CMD_SPECIAL, QByteArray(), QByteArray(), showProgressInfo )
 {
+  d = new DavJobPrivate;
   // We couldn't set the args when calling the parent constructor,
   // so do it now.
@@ -54,4 +61,5 @@ DavJob::DavJob( const KURL& url, int met
     staticData = "<?xml version=\"1.0\" encoding=\"utf-8\"?>\r\n" + request.utf8();
     staticData.truncate( staticData.size() - 1 );
+    d->savedStaticData = staticData.copy();
   }
 }
@@ -89,8 +97,14 @@ void DavJob::slotFinished()
                 el.appendChild( textnode );
                 root.appendChild( el );
+                delete d; // Should be in virtual destructor
+                d = 0;
+        } else {
+                delete d; // Should be in virtual destructor
+                d = 0;
         }
 
         // kdDebug() << m_response.toString() << endl;
         TransferJob::slotFinished();
+        if( d ) staticData = d->savedStaticData.copy(); // Need to send DAV request to this host too
 }
 

--- kdelibs/kio/kio/davjob.h  #1.5:1.6
@@ -79,5 +79,6 @@ namespace KIO {
         TransferJob *m_subJob;
     private:
-        class DavJobPrivate* d;
+        class DavJobPrivate;
+        DavJobPrivate *d;
         QString m_str_response;
         QDomDocument m_response;
[prev in list] [next in list] [prev in thread] [next in thread]